[Enhancement]: Add interface service_policy parameter
#332
Conversation
acch
force-pushed
the
306-interface-service_policy-parameter
branch
2 times, most recently
from
71823b2 to
1de03df
Compare
acch
requested review from
carchi8py,
chuyich,
suhasbshekar and
wenjun666
as code owners
acch
force-pushed
the
306-interface-service_policy-parameter
branch
from
d2aa5ab to
2552062
Compare
acch
force-pushed
the
306-interface-service_policy-parameter
branch
from
39b39bc to
dd0999b
Compare
| * "default-management" if scope is cluster and IPspace is not Cluster (not yet implemented) | ||
| * "default-cluster" if scope is cluster and IPspace is Cluster (not yet implemented) | ||
| */ | ||
| Default: stringdefault.StaticString("default-data-files"), |
There was a problem hiding this comment.
In ONTAP 9.6 API document:
If not specified in POST, the following default property values are assigned:
:
service_policy:
default-data-files if scope is svm
default-management if scope is cluster and IPspace is not Cluster
default-cluster if scope is svm and IPspace is Cluster
The default value can be found in query API. And it does not have to be set in the POST API call. So, it should not be set here.
There was a problem hiding this comment.
Hello @chuyich, thank you very much for reviewing this PR.
I did add a default value for the following reason: without a default value, when there is no configuration supplied, Terraform will mark the attribute as unknown. Unknown attributes are constantly displayed as "(known after apply)" in plan outputs... the default value is to reduce these "(known after apply)" plan outputs.
I'm happy to remove the default value, though - just wanted to double-check that the behavior mentioned above is indeed desired in this case.
Thanks much for a quick confirmation!
There was a problem hiding this comment.
Since it could be one of 3 values based on the scope, set any of them may not be correct. It's better to use this way:
https://github.com/NetApp/terraform-provider-netapp-ontap/blob/integration/main/internal/provider/name_services/name_services_ldap_resource.go#L106
PlanModifiers: []planmodifier.String{ stringplanmodifier.UseStateForUnknown(), },
We found setting default values may cause issues in some cases. The above will cover the case you mentioned. Also after you remove the default value part, the parameter handling needs to be adjusted accordingly. You may use the above case as a reference.
There was a problem hiding this comment.
Understood. I've removed the default value, and added logic for fetching the value computed by ONTAP API instead.
Signed-off-by: Achim Christ <[email protected]>
Signed-off-by: Achim Christ <[email protected]>
… parameter Signed-off-by: Achim Christ <[email protected]>
Signed-off-by: Achim Christ <[email protected]>
Signed-off-by: Achim Christ <[email protected]>
acch
force-pushed
the
306-interface-service_policy-parameter
branch
from
dd0999b to
57fc48c
Compare
Signed-off-by: Achim Christ <[email protected]>
|
Thanks @carchi8py and @chuyich for your feedback! I've removed the default value for Thanks much! |
Adds ability to configure
service_policyparameter of IP Interfaces.Closes #306.
Acceptance tests pass:
$ TF_ACC=1 go test ./internal/provider/networking/network_ip_interface_resource_test.go -v === RUN TestAccNetworkIpInterfaceResource --- PASS: TestAccNetworkIpInterfaceResource (4.44s) PASS ok command-line-arguments 4.449s$ TF_ACC=1 go test ./internal/provider/networking/network_ip_interface_resource_alias_test.go -v === RUN TestAccNetworkIpInterfaceResourceAlias --- PASS: TestAccNetworkIpInterfaceResourceAlias (3.93s) PASS ok command-line-arguments 3.935sExample Terraform Configuration: